-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse proxy caching #285
Conversation
@@ -72,6 +72,9 @@ http { | |||
client_max_body_size <%= node['nginx']['client_max_body_size'] %>; | |||
<% end -%> | |||
|
|||
<% if node['nginx']['reverse_proxy_caching'] == 'on' -%> | |||
proxy_cache_path <%= node['nginx']['proxy_cache_path'] %>; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a <% end -%>
missing to closes the if
.
Also what do you think about only testing for presence of the node['nginx']['reverse_proxy_caching']
attribute, instead of equality testing for the value "on"
(like done with the <% if node['nginx']['enable_rate_limiting'] -%>
below and corresponding attribute).
Took in changes from your comment |
@azretd Can you squash these commits? 5 seem a bit hefty for the amount of change here. |
Changes Unknown when pulling e2e2175 on azretd:feature-reverse-proxy into * on miketheman:master*. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.